feat: Standardize Bicep Parameters for MACAE #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishalS-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Roopan-Microsoft
approved these changes
Jun 12, 2025
blessing-msft
pushed a commit
that referenced
this pull request
Aug 1, 2025
feat: Standardize Bicep Parameters for MACAE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces enhancements to parameter customization for Azure deployments, including documentation updates and infrastructure configuration changes. The key changes focus on enabling users to customize resource names, regions, and telemetry settings more easily.
Documentation Updates:
docs/CustomizingAzdParameters.md: Added a new section detailing how to customize resource names and other deployment parameters, including a table of default values and instructions for overriding them usingazd env set.documentation/DeploymentGuide.md: Updated the deployment guide to link to the new customization documentation and revised the list of configurable settings to reflect the new parameters.Infrastructure Configuration:
infra/main.bicepparam: Updated parameter definitions to read environment variables for resource name prefix, region, OpenAI location, and telemetry enablement, replacing hardcoded defaults.infra/main.waf-aligned.bicepparam: Similar updates to parameter definitions as inmain.bicepparam, ensuring consistency across different infrastructure configurations.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information